Wave 35: govern consumer contracts and CI performance - #395
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ty-everett
left a comment
There was a problem hiding this comment.
Administrative exact-head review by ty-everett for 5ec9965.
Reviewed the complete Wave 35 diff and the follow-up static-analysis refactor. The changes establish machine-enforced consumer profiles for all 30 public packages, add evidence-backed CI performance governance, and harden the exact packed VeriFast browser/WASM/worker/UMD contracts. Public exports, package paths, runtime and protocol behavior, storage and error behavior, defaults, and service CORS/CSP policy remain unchanged. No package publication, tag, release, or deployment is included.
Exact-head evidence: 66 checks passed, zero failed or pending; merge-gate passed; Sonar has 0 new issues, 0 accepted issues, and 0 hotspots; CodeQL actions and JavaScript/TypeScript passed; Socket and dependency review passed; Codecov covers all modified coverable lines; full coverage, mutation, platform, infrastructure, conformance, docs, build, lint, type, policy, and package contract lanes passed. No unresolved review threads or actionable comments remain.
GitHub does not permit an author to submit APPROVE on the authors own pull request, so this COMMENT records the requested substantive ty-everett administrative review without waiting for an unrelated reviewer. The exact head is suitable for the authorized admin squash merge.



Summary
Wave 35 directly advances the remaining production-readiness program in tracker #324 by replacing inferred package support with machine-governed consumer contracts, completing the outstanding VeriFast browser/WASM distribution proof, and adding an evidence-backed CI performance trend gate.
What changed
@bsv/verifastto0.3.2and tests exact packed tarballs through Node ESM/CommonJS, Vite, esbuild, real Chromium, workers, UMD, strict CSP, normal streaming WASM, and the ArrayBuffer MIME fallback.Tracker #324 disposition
This PR is intended to complete the applicable all-package consumer matrix, all-package profile assignment, declared Node ESM/CommonJS verification, Metro/Hermes profile coverage, VeriFast WASM/worker/CSP/fallback verification, compressed browser payload budgets, and CI trend-budget control. It materially advances—but does not overclaim completion of—the broader exact-tarball/sourcemap/runtime matrix and resource telemetry items. The deferred testing/QA-hardening phase remains deferred.
Compatibility and impact
@bsv/verifast@0.3.2is a source candidate only. This PR does not publish packages, create tags/releases, or deploy anything.Validation
Validated on Node 24.18.0 and pnpm 10.33.2:
pnpm audit:security: no known vulnerabilitiesCI, CodeQL, Sonar zero-new-findings, Codecov, and the remaining merge gates must pass on the exact PR head before merge.