Fix getStores endpointURL under production minification - #419
Open
sirdeggen wants to merge 1 commit into
Open
Conversation
Production minifiers rename StorageClient, so getStores().endpointURL was always undefined for remote providers while backup sync still worked. Duck-type provider.endpointUrl instead.
sirdeggen
requested review from
BraydenLangley,
tonesnotes and
ty-everett
as code owners
July 31, 2026 22:30
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WalletStorageManager.getStoreEndpointURLusedconstructor.name === 'StorageClient', which fails after Vite/esbuild/webpack minify renames the class._backups), but clients that match stores by URL (e.g. bsv-desktop Make Primary) sawendpointURL: undefinedand failed with "No storage provider matching …".provider.endpointUrlinstead.Changes
WalletStorageManager.getStoreEndpointURL: duck-typeendpointUrl; document whyconstructor.nameis unsafegetStores()exposureTest plan
pnpm exec jest --runTestsByPath test/storage/getStoreEndpointURL.test.ts(5 passed)https://store-us-1.bsvb.techsucceeds