fix(express): share host runtime across framework extensions - #420
Merged
Conversation
ty-everett
requested review from
BraydenLangley,
sirdeggen and
tonesnotes
as code owners
July 31, 2026 22:54
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This was referenced Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Program and scope
@bsv/paymail,@bsv/auth-express-middleware,@bsv/payment-express-middleware, and@bsv/wallet-relayextend a host application and are fixed here.@bsv/overlay-expressand@bsv/wallet-toolboxinstantiate and own their internal servers, so their regular Express dependencies remain correct.1d0a9b79ec796112581f0a6bc6abbadf84d71b25Impact
Affected packages and intended patch versions (publication occurs only through the protected release workflow after merge):
@bsv/auth-express-middleware@2.1.7@bsv/payment-express-middleware@2.1.5@bsv/paymail@2.4.6@bsv/wallet-relay@0.3.4Verification
health:check(129/129), andaudit:security(zero known vulnerabilities) all pass.@types/express4.17.23 and Express 5.2.1 +@types/express5.0.6, with no nested Express runtime or type graph.auth-express-bytes82.67%;payment-replay95.24%;paymail-address92.16%;wallet-pairing89.29%.Security and dependencies
The host framework and its matching declarations are required peers for packages whose root API mounts Express routers/middleware. Wallet Relay keeps them optional because its Express integration is an optional server surface. Development copies remain only for each package's own build/tests. Consumers therefore receive one compatible Express 4 or 5 graph.
Dependency evidence
>=22; exact tarballs compile against both supported Express majors, their matching declarations, strict TypeScript 5.9, and SDK 2.2.17.Release and operations
After protected npm publication, downstream p2ppsr consumers will adopt the released versions, validate in CI/staging, and deploy through their owning repositories. Rollback is a consumer version pin; no protocol or persisted-data migration is involved.
Completion evidence