Repository navigation
docs: remove stale maintainer notes and review plan - #122
Merged
Merged
Conversation
leoafarias
added a commit
that referenced
this pull request
Sep 23, 2026
Resolve against #122 and #123 without restoring what they removed: - Keep DeckLibraryController.openDeck; the ownership fix now reads it in production. - Serialize retained generations with SlideSerializer instead of reviving DeckMarkdownCodec.encode. - Drop the PDF dialog's disposed check rather than restoring PdfController.disposed; the dialog disposes a controller only when it replaces it or unmounts. - Point imports and audit references at features/ai/generation, and state the renderer, assembly, and Mermaid decisions inline now that their notes are gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Remove temporary maintainer notes and a finished review plan from
docs/. What they recorded is already in the merged PRs and git history.Removed:
docs/generation_and_rendering_review_plan.md: its own retirement condition was met. Slide assembly was consolidated intopackages/builder/lib/src/parsers/slide_assembler.dart, and the renderer decision was to keepflutter_markdown_plus(chore: align analysis and record architecture decisions #113).docs/maintainers/analysis-parity.mddocs/maintainers/first-principles-status.mddocs/maintainers/renderer-and-assembly-evaluation.mddocs/maintainers/adr/0001-runtime-mermaid-rendering.mdThe only in-tree reference was a comment in
.github/workflows/test.ymlthat pointed toanalysis-parity.md. The comment still says DCM does not run in CI, but it no longer links to the removed file.User-facing docs (
docs/**/*.mdx,docs.json) are unchanged.Impacted packages
None. This changes documentation and one CI comment.
Commands run
git grepfor every removed path: no remaining references.