Set default configuration in Dockerfile using environment variables#47
Open
AlexandreCarlton wants to merge 2 commits intobuchgr:masterfrom
Open
Set default configuration in Dockerfile using environment variables#47AlexandreCarlton wants to merge 2 commits intobuchgr:masterfrom
AlexandreCarlton wants to merge 2 commits intobuchgr:masterfrom
Conversation
This will allow users to easily change the port and directory without having to override the entrypoint in a child image.
Collaborator
|
LGTM, or we could change |
Contributor
Author
|
I considered this, but if we had: CMD ["--port=80", "--dir=/data"]then a user already providing arguments to the
Specifying these values as environment variables seemed better to avoid breaking changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow users to easily change the port and directory without having to override the entrypoint.
I also updated the README to document the usage of these environment variables.