fix http regex string to add support for cas.v2 http requests#663
fix http regex string to add support for cas.v2 http requests#663HunterCrosland wants to merge 5 commits intobuchgr:masterfrom
Conversation
|
I am not sure why this is failing HTML requests, but we are getting error responses locally on latest container version. CURL requests to valid SHAs using /cas/SHA returns I can investigate this more next week. |
Realized regex match groups got messed up, fixed it. |
mostynb
left a comment
There was a problem hiding this comment.
Thanks for the contribution- I assume you would like this behaviour because you're chaining two bazel-remote instances with the http proxy backend? If that is the case, I wonder if it would be better to add a new option to the http proxy backend instead?
You are spot-on with the why -- and I really don't mind how. I am not entirely familiar with the routing on the backend, so that's probably something I will need to do over a weekend. In the meantime for our CI we've rolled back to a previous image version built prior to cas.v2 support. I built an image based on the changes I made here but it didn't have the correct entrypoint by default, and that's going to be another weekend issue. |
|
This used to work out of the box before bazel-remote had a compressed storage option (which is now the default). You should still be able to use a current build to chain together two bazel-remote instances with the http proxy backend by using If the front end uses the default |
|
|
Adds support to http.go regex string to allow cas.v2 in http request