[metrics] add maximum disk size as metric#704
Open
martijndegouw wants to merge 1 commit intobuchgr:masterfrom
Open
[metrics] add maximum disk size as metric#704martijndegouw wants to merge 1 commit intobuchgr:masterfrom
martijndegouw wants to merge 1 commit intobuchgr:masterfrom
Conversation
This allowes for easier monitoring of how much of the assigned space is used.
Collaborator
|
Hi, I'm not sure how useful it is to monitor this value, since you typically set it relative to the filesystem space you have available and then don't need to think about it. What's the use case for adding this? |
Contributor
Author
|
Hi, The reason for adding it is that the bazel_remote_disk_cache_logical_bytes metric has no reference now. Monitoring does not know how much head room is left for the bazel-remote cache instance. If a more dynamic value is preferred this metric could be changed to bazel_remote_disk_cache_logical_bytes_free for example. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allowes for easier monitoring of how much of the assigned space is used.