Add ability to set environment variables for an execution#4
Open
khamer wants to merge 1 commit intobuddy-works:masterfrom
Open
Add ability to set environment variables for an execution#4khamer wants to merge 1 commit intobuddy-works:masterfrom
khamer wants to merge 1 commit intobuddy-works:masterfrom
Conversation
Author
|
I missed the 'Pass arguments' action - there might be worth I could do on this PR to better integrate it with that action. |
Contributor
|
Hey @khamer, thanks for contribution, can you also add test for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working through some use cases for the buddy-cli, and the ability to set environment variables for a specific execution seems really handy, and already exists within the API.
This PR adds that functionality, following this format:
I added it to the README as well. Let me know what you think and if there's other changes you'd like to see.