Repository navigation
dd-trace dependency #4
Description
I see the dd-trace dependency is only in the require-dev section of composer.json. However, given the implementation, it looks like dd-trace is expected to be present. Should we move this into the full require section instead?
Metadata
Metadata
Assignees
Labels
No labels
Activity
erickhun commentedon Nov 25, 2019
ah good one @colinscape !
I need to double check on that by using the lib in a project, but I remembered with
buffer-web, having the php dd-trace in composer + dd-trace binary package (dpkg) created some namespace conflicts. I think this is because the php library is already present in the binary package. (it's also why I had to remove it from https://github.com/bufferapp/buffer-web/pull/16716 )If that's the case we would certainly make a check, perhaps by detecting if the
Datadog\DDTracenamespace exist if anyone use the Bufflog php librarycolinscape commentedon Nov 25, 2019
Ah, interesting! Yup, that feels like a good one to check out how things behave in practice! 👍
erickhun commentedon Dec 12, 2019
For that one, I think we will need a way to detect if the dd tracer extension has been properly setup in the docker image 🤔