Open
Conversation
483903c to
3ebc783
Compare
3ebc783 to
e5db0b7
Compare
trvrnrth
commented
Nov 3, 2023
Comment on lines
+61
to
+62
| return "Error: #{data[:error]}" if data[:error] | ||
| "Errors: #{data[:errors]}" if data[:errors] |
Author
There was a problem hiding this comment.
Alternatives which break complete backwards compat for message parsing would be:
errors = Array(data[:errors] || data[:error])
"Errors: #{errors}" if errors.any?
or
errors = data[:errors] || (data[:error] ? [data[:error]] : nil)
"Errors: #{errors}" if errors.any?
Author
There was a problem hiding this comment.
We may also want to pretty print lists of errors in some manner rather than relying on Array::to_s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Include lists of errors as returned from some API endpoints (eg. configure an integration) in raised
Bugsnag::Api::Errormessages.Design
Added secondary check for
errorsin order to maintain existing error message for possible compatibility reasons.Changeset
errorsTesting
Manually tested with:
which raises: