Repository navigation
Update to Go 1.27 - #460
Merged
Merged
Conversation
edmorley
added
type:dependency-upgrade
edmorley
added
type:dependency-upgrade
edmorley
force-pushed
the
edmorley/go-1.27
branch
from
October 5, 2026 14:40
9bcc10f to
11551b4
Compare
The `action-*.yml` workflows only ran when an action's source or `internal/` changed, so changes to the `Dockerfile`, `go.mod`/`go.sum` (such as Dependabot's Go dependency PRs) or the workflow itself never test-built the images. Signed-off-by: Ed Morley <emorley@salesforce.com>
So the Go version only needs updating in one place. The `Dockerfile` now takes the major.minor of the `go` directive as a `GO_VERSION` build arg, and the unit tests pass it to `setup-go` with `check-latest`, so both use the latest patch release rather than the exact (and often outdated) patch version in the `go` directive. Signed-off-by: Ed Morley <emorley@salesforce.com>
Signed-off-by: Ed Morley <emorley@salesforce.com>
edmorley
force-pushed
the
edmorley/go-1.27
branch
from
October 5, 2026 14:47
11551b4 to
a3ba903
Compare
edmorley
marked this pull request as ready for review
October 5, 2026 14:50
edmorley
enabled auto-merge (squash)
October 5, 2026 14:50
hone
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to Go 1.27, and derives the Go version from the
godirective ingo.mod, so it only needs updating in one place:Dockerfilenow takes the major.minor of thegodirective as aGO_VERSIONbuild arg, passed by theaction-*.ymlworkflows.setup-gowithcheck-latest. Using only the major.minor means both get the latest patch release, rather than the exact (and often outdated) patch version in thegodirective.action-*.ymlworkflows now also run when theDockerfile,go.mod/go.sumor the workflow itself change, so changes like these (and Dependabot's Go dependency PRs) test-build the images.