Add Kubernetes secret RBAC support to Helm chart#931
Add Kubernetes secret RBAC support to Helm chart#931burningalchemist merged 3 commits intoburningalchemist:masterfrom
Conversation
|
@zofer1zohargo since the RBAC bindings are new to the chart and also simply new template files, let's update the version to The CI will break after the change as I haven't made the app release yet. It's ok for now, we may convert the PR to draft. Once it's released, we re-run the PR and merge it. 👍 Please don't forget to run |
Sure I will do that. |
7a1eaac to
f524a98
Compare
|
I made no helm changes to use other values so gen docs made no changes. This means that if you ask sql exporter helm to create service account it will be granted automatically the right to read secrets from the namespace it is installed. We could have done all sorts of helm tricks in helm charts to mount it and process the file later but this eventually implies that we read secrets and deploy time instead of runtime. I find runtime neater so you don't need to deploy again when password changes. I find that creating the role and binding with another flag is an overkill. We can add it later |
|
@zofer1zohargo Yeah, agreed. Ok, then we wait for the release, and re-run the tests and we should be good to go. I'll tag you here 👍 |
|
@zofer1zohargo v0.21 has been released, I also re-ran the failed helm workflow. Please have a look in case you want to adjust the PR and rebase onto the recent master. Otherwise, I'm ready to merge. 👍 |
f524a98 to
7b0e743
Compare
It seems that I had some mix up and another development was pushed to that branch. I will need to sort it out for a clean build |
ed83cdc to
ad92ade
Compare
Add Role and RoleBinding templates for reading Kubernetes secrets. Bump Helm chart version to 0.16.1. Fix service account name resolution in _helpers.tpl. Made-with: Cursor
ad92ade to
13ae99d
Compare
Made-with: Cursor
|
Should be fine now |
Add Role and RoleBinding templates for reading Kubernetes secrets.
Bump Helm chart version to 0.16.1.
Fix service account name resolution in _helpers.tpl.