changed rule for Mac and added Apple Silicon variant #567
+30
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
It seems that Homebrew builds avr-gcc 9 from scratch. Have you tried other versions? |
Contributor
Author
|
It seems that all avr-gcc versions for Intel Macs are built from source. I have no idea why. I'll open an issue with them. |
Collaborator
|
That sounds a good idea, thanks. If the long build time becomes a problem, the script could be modified to skip building tests and examples. They do not get saved. But probably all the build scripts should be running the tests. |
Contributor
Author
|
It is a feature, not a bug: osx-cross/homebrew-avr#380 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the existing CI script, only one binary is produced for macOS, and it is claimed to be an Intel binary. However, it turns out that an Apple Silicon binary is produced because the runner is macos-latest, which, according to the documentation https://docs.github.com/en/actions/how-tos/write-workflows/choose-where-workflows-run/choose-the-runner-for-a-job#standard-github-hosted-runners-for-public-repositories, is an arm64 runner.
The corrected script now produces an ARM and an Intel binary for the Macs. Note that the latter one takes 1 hour (since it builds gcc from source, I believe).