Fix: workaround for using tools with no go directive in their go.mod #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://go.dev/ref/mod#go-mod-file-go, prior to Go 1.21, the go directive was option. This seems to not be supported in bingo. This commit only changes the fallback value used when a go.mod file does not contain the version. This semantically means that any go version should be able to compile this. I encountered the issue while trying to use bingo to install github.com/betacraft/easytags Their go.mod is completely empty, which causes a panic on if semver.MustParse(targetModParsed.GoVersion()).GreaterThan(runnable.GoVersion()) { `get.go:723`
drornir
changed the title
Contributor
Author
|
@bwplotka do i need to improve something in order to get this merged? thanks! |
Owner
|
Do you mind pushing empty commit or adding a comment why |
Contributor
Author
bwplotka
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://go.dev/ref/mod#go-mod-file-go, prior to Go 1.21, the go directive was option.
This seems to not be supported in bingo. This commit only changes the fallback value used when a go.mod file does not contain the version. This semantically means that any go version should be able to compile this.
I encountered the issue while trying to use bingo to install github.com/betacraft/easytags Their go.mod is completely empty, which causes a panic on
if semver.MustParse(targetModParsed.GoVersion()).GreaterThan(runnable.GoVersion()) {
get.go:723Steps to recreate:
Thanks for the great tool!