Skip to content

Add toArrayFull() #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byjg merged 2 commits into from
Jul 3, 2025
+58 −9
Merged

Add toArrayFull() #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec08d17
includes the old xml conversion toArray
leonardomunsa Jul 3, 2025
5880d0c
Merge pull request #9 from leonardomunsa/fix/to-array
byjg Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 37 additions & 5 deletions src/XmlNode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,14 +260,13 @@ public function removeTagName(string $tagName): bool
}
}


public function toArray(Closure $func = null): array
public function toFullArray(): array
{
$sxml = simplexml_import_dom($this->DOMNode());
return [$sxml->getName() => $this->_toArray($sxml)];
return [$sxml->getName() => $this->_toFullArray($sxml)];
}

protected function _toArray(SimpleXMLElement $node): array|string
protected function _toFullArray(SimpleXMLElement $node): array|string
{
$hasAttributes = (count($node->attributes()) > 0);
$hasChildren = (count($node->children()) > 0);
Expand All @@ -289,7 +288,7 @@ protected function _toArray(SimpleXMLElement $node): array|string
if ($hasChildren) {
foreach ($node->children() as $child) {
$childName = $child->getName();
$childData = $this->_toArray($child);
$childData = $this->_toFullArray($child);

if (isset($output[$childName])) {
if (!is_array($output[$childName]) || !isset($output[$childName][0])) {
Expand All @@ -309,6 +308,39 @@ protected function _toArray(SimpleXMLElement $node): array|string
return $output;
}

public function toArray(Closure $func = null): array
{
return $this->_toArray($this->DOMNode(), $func);
}

protected function _toArray(SimpleXMLElement|DOMNode|array $arr, Closure|null $func = null): array
{
if ($arr instanceof SimpleXMLElement) {
return $this->_toArray((array) $arr, $func);
}
Comment on lines +316 to +320
Copy link
Copy Markdown

@korbit-ai korbit-ai Bot Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infinite Recursion Risk category Functionality

Tell me more
What is the issue?

The _toArray method contains potential infinite recursion when handling SimpleXMLElement instances.

Why this matters

If a SimpleXMLElement is passed, it will continuously cast to array and call itself, leading to a stack overflow.

Suggested change ∙ Feature Preview

Modify the method to handle SimpleXMLElement directly:

protected function _toArray(SimpleXMLElement|DOMNode|array $arr, Closure|null $func = null): array
{
    if ($arr instanceof SimpleXMLElement) {
        $arr = (array) $arr;
    } elseif ($arr instanceof DOMNode) {
        $arr = (array) simplexml_import_dom($arr);
    }

    $newArr = array();
    if (!empty($arr)) {
        foreach ($arr as $key => $value) {
            $newArr[$key] = (
                is_array($value)
                || ($value instanceof DOMNode)
                || ($value instanceof SimpleXMLElement)
                    ? $this->_toArray($value, $func)
                    : (!empty($func) ? $func($value) : $value)
            );
        }
    }
    return $newArr;
}
Provide feedback to improve future suggestions

Nice Catch Incorrect Not in Scope Not in coding standard Other

💬 Looking for more details? Reply to this comment to chat with Korbit.


if ($arr instanceof DOMNode) {
return $this->_toArray((array) simplexml_import_dom($arr), $func);
}

$newArr = array();
Comment on lines +316 to +326
Copy link
Copy Markdown

@korbit-ai korbit-ai Bot Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complex Type Handling in Array Conversion category Design

Tell me more
What is the issue?

Method accepts multiple types (SimpleXMLElement|DOMNode|array) and has recursive type casting, making the flow hard to follow and maintain.

Why this matters

Violates SOLID's Single Responsibility Principle by handling multiple type conversions in one method. This complexity makes the code harder to test and more prone to bugs.

Suggested change ∙ Feature Preview

Split into specialized methods for each type:

protected function convertSimpleXmlToArray(SimpleXMLElement $element): array;
protected function convertDomNodeToArray(DOMNode $node): array;
protected function processArrayValues(array $input): array;
Provide feedback to improve future suggestions

Nice Catch Incorrect Not in Scope Not in coding standard Other

💬 Looking for more details? Reply to this comment to chat with Korbit.

if (!empty($arr)) {
foreach ($arr as $key => $value) {
$newArr[$key] =
(
is_array($value)
|| ($value instanceof DOMNode)
|| ($value instanceof SimpleXMLElement)
? $this->_toArray($value, $func)
: (!empty($func) ? $func($value) : $value)
);
}
}

return $newArr;
}


/**
* @param string|null $prefix
* @param string $uri
Expand Down
25 changes: 21 additions & 4 deletions tests/XmlUtilTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,19 +310,36 @@ public function testRemoveNode(): void

}

public function testXml2Array(): void
public function testXml2Array1(): void
{
$file = new File(__DIR__ . '/buggy.xml');
$xml = new XmlDocument($file, preserveWhiteSpace: false);

$array = $xml->toArray();
$this->assertEquals([ "node" => [ "subnode" => "value"]], $array);
}

public function testXml2Array2(): void
{
$xml = new XmlDocument('<root><node param="pval">value</node></root>');

$array = $xml->toArray();
$this->assertEquals([ "node" => "value"], $array);
}

public function testXml2FullArray(): void
{
$file = new File(__DIR__ . '/buggy.xml');
$xml = new XmlDocument($file, preserveWhiteSpace: false);

$array = $xml->toFullArray();
$this->assertEquals(['root' => [ "node" => [ "subnode" => "value"]]], $array);
}

public function testXmlToArrayWithAttributeAndNoText(): void
{
$xml = new XmlDocument('<root><node param="pval"/></root>');
$array = $xml->toArray();
$array = $xml->toFullArray();

$expected = [
'root' => [
Expand All @@ -338,7 +355,7 @@ public function testXmlToArrayWithAttributeAndNoText(): void
public function testXmlToArrayWithAttributeAndText(): void
{
$xml = new XmlDocument('<root><node param="pval">value</node></root>');
$array = $xml->toArray();
$array = $xml->toFullArray();

$expected = [
'root' => [
Expand All @@ -356,7 +373,7 @@ public function testXmlToArrayWithMixedContent(): void
{
$xmlString = '<root><node param="pval">value<other>value</other><node2 a="2"></node2></node></root>';
$xml = new XmlDocument($xmlString);
$array = $xml->toArray();
$array = $xml->toFullArray();

$expected = [
'root' => [
Expand Down