Remove unused dev and research dependencies - #121
Open
usehoplite[bot] wants to merge 1 commit into
Open
Conversation
markdown-it-py (dev extra) and tokenizers (research extra) are never imported anywhere in the repository; drop them and their transitive closure from the lockfile. pytest, fonttools, and uharfbuzz remain: pytest is used by the test suite, and fonttools/uharfbuzz are lazily imported by tools/h14_mechanism_scan.py and tools/h16_shaping_closure_scan.py. Co-authored-by: Yinhao Chen <pxxyhc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency audit of the project's Python manifests. Two declared dependencies are never imported anywhere in the repository and were safely removed; everything else was verified in use and kept.
Removed (proven unused)
markdown-it-py==4.2.0(dev extra) — noimport markdown_itanywhere in the repo; the only occurrences were the manifest and lockfile.tokenizers>=0.20(research extra) — noimport tokenizers/from tokenizersanywhere in the repo (prose references to "tokenizers" in docs/evidence are unrelated to the HF package).Kept (verified in use)
pytest— imported throughouttests/, run by CI.fonttools/uharfbuzz— lazily imported bytools/h14_mechanism_scan.pyandtools/h16_shaping_closure_scan.py; the research extra contents are asserted bytests/test_cycle8_post_sanitizer_extended.py.requirements-smoke.txt(torch/transformers) — active CI dependency, not part of the uv lockfile, unchanged.bindings/node,editors/vscode,crates/fuckmark-scan— declared zero external dependencies already.Lockfile
uv.lockregenerated: 26 packages → 9 (pytest + fonttools + uharfbuzz and their real transitive deps only). Counts as 267 lines removed.Verification
uv lock --check --python 3.12passes with the local uv (0.9.28) and with CI-pinneduv==0.10.0.uv sync --extra dev --extra researchresolves and installs cleanly.python -m pytest -q— all tests pass, includingtests/test_m0_source_freeze.py(lockfile present/project-bound),tests/test_cycle8_post_sanitizer_extended.py(research extra contract),tests/test_cli.py,tests/test_project_identity.py,tests/test_version.py.