Fix potential error when multiple AppInstaller versions installed and add explicit machine scope to Test-WinGetApp#11
Open
Skorfulose wants to merge 2 commits intobyteben:mainfrom
Open
Conversation
Previously, Microsoft.DesktopAppInstaller packages where alphabetically sorted descending to find the latest one. This led to wrong results, e.g. in this case: C:\Program Files\WindowsApps\Microsoft.DesktopAppInstaller_1.4.3161.0_x64__8wekyb3d8bbwe C:\Program Files\WindowsApps\Microsoft.DesktopAppInstaller_1.21.2721.0_x64__8wekyb3d8bbwe C:\Program Files\WindowsApps\Microsoft.DesktopAppInstaller_1.16.12653.0_x64__8wekyb3d8bbwe
Without explicitly specifying the scope to the winget list command, it will query the user scope. We want it to query the machine scope of course.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes two things I found during testing in our corp environment: