Make StarlingMonkey location overridable#196
Merged
guybedford merged 1 commit intobytecodealliance:mainfrom Mar 6, 2025
Merged
Make StarlingMonkey location overridable#196guybedford merged 1 commit intobytecodealliance:mainfrom
guybedford merged 1 commit intobytecodealliance:mainfrom
Conversation
This adds the ability to override the location the `StarlingMonkey` source is found at via the env var `STARLINGMONKEY_SRC`. This makes it much easier to develop against a local version of StarlingMonkey. I also cleaned up the `Makefile` a bit, and moved some more stuff over into the `CMakeLists.txt` file, but that's really just minor cleanup.
tschneidereit
force-pushed
the
overridable-starlingmonkey
branch
from
c93382b to
656d6e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to override the location the
StarlingMonkeysource is found at via the env varSTARLINGMONKEY_SRC. This makes it much easier to develop against a local version of StarlingMonkey.I also cleaned up the
Makefilea bit, and moved some more stuff over into theCMakeLists.txtfile, but that's really just minor cleanup.