feat: reenable weval patches#303
Merged
andreiltd merged 10 commits intobytecodealliance:mainfrom Mar 4, 2026
Merged
Conversation
andreiltd
force-pushed
the
revive-weval
branch
2 times, most recently
from
1ccf3a7 to
1dd56b5
Compare
andreiltd
force-pushed
the
revive-weval
branch
from
1dd56b5 to
10750de
Compare
cfallin
reviewed
Feb 24, 2026
The wasi spce doesn't really say anything about the order of ready handles, it only says that he result list<u32> contains one or more indices of handles in the argument list that is ready for I/O. We should find the oldest task. This was working previously because wasmtime v29 was using HashMap for iterating pollables for which the iteration order was random and just happened to work. Recent version of wasmtime changes that to use BTreeMap instead which broke the assumptions here.
Most of the fixes are mechanical: - changing c style enums to enum classes and then using std::to_underlying to convert to numeric types - replacing printf with std::println - fixing stack address escape in builtin.h file: returning &self in the tuple gives the caller a dangling pointer, but the pointer where never actually used.
tschneidereit
approved these changes
Mar 3, 2026
Member
tschneidereit
left a comment
tschneidereit
left a comment
There was a problem hiding this comment.
Looks great, with the couple of comments addressed!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This an attempt to re-apply weval patches on top of FF140 to test weval failures. Because we don't have prebuilt image for wevaled spidermonkey the build system will build spidermonkey from source.
The firefox has been updated to the latest stable: 147_0_4
There is a notable change in loading module API in ff147: new API is async-capable
ModuleLoadHookreturns bool and must callFinishLoadingImportedModuleon success.Depends on bytecodealliance/firefox#1