wasm-pkg-client: validate semver compliance on publish#213
Conversation
|
Hey @ryan-surname-p it looks like some conflicts creeped in -- apologies for the inconvenience but would you mind resolving those? Then we can get this merged. |
|
No problem at all. @mkatychev actually reached out to me about this and some work they have in flight as well. If I understood their request correctly we'd like for that to land first and then work some version of this onto that. This request seemed reasonable enough to me so the current plan is to monitor the progress of 215 and then adjust accordingly. |
|
I'd like to hear @vados-cosmonic's thoughts on which should land first. I suppose one of us will be handling gnarly merge conflicts regardless so it may be fairer for @ryan-surname-p's changes to land first. |
cbca048 to
77a1e3e
Compare
|
FWIW I'm happy enough to handle either approach I just wanted to make sure everyone was working with the same set of assumptions. |
|
@ryan-surname-p the multi publish package PR has landed, could you address the conflicts and #213 (comment)? |
|
Thanks for the heads up, I'll get to this first thing tomorrow. I followed up on #213 (comment) but I realize now you weren't actually able to see it because I never submitted my review 🤦 |
0199b6f to
4e10a3a
Compare
|
If we can address||change the nits about |
4e10a3a to
43ed86c
Compare
1903ad5 to
57ee7cd
Compare
43ed86c to
2cf52d5
Compare
closes #128
Summary
By default publish:
The changeset is fairly large I know though a material amount of the new code are tests and moving functions around to keep things readable.