Allow bracketed IPv6 authorities without ports in wasi-http p3#13697
Open
modernzju wants to merge 1 commit into
Open
Allow bracketed IPv6 authorities without ports in wasi-http p3#13697modernzju wants to merge 1 commit into
modernzju wants to merge 1 commit into
Conversation
Signed-off-by: modernzju <modernzju@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the wasi-http p3
set_authorityvalidation to allow bracketed IPv6 authorities without an explicit port, such as[::].Previously p3 treated any
:in the authority string as indicating a port. That incorrectly rejected bracketed IPv6 literals without ports because their colons are part of the host. This keeps the existing validation for invalid ports, such asbad-port:99999, while only treating a bracketed IPv6 authority as having a port when the suffix after]starts with:.A test case was added to align p3 behavior with the existing p2 coverage for
[::]:443and[::].Testing:
cargo fmt --checkcargo test -p wasmtime-wasi-http --features p3,default-send-request p3_http_outbound_request_response_build