Skip to content

feat: skills download and register in ecs env#210

Open
YumengBao wants to merge 1 commit intomainfrom
feat/skills_in_ecs
Open

feat: skills download and register in ecs env#210
YumengBao wants to merge 1 commit intomainfrom
feat/skills_in_ecs

Conversation

@YumengBao
Copy link
Copy Markdown
Collaborator

No description provided.

@YumengBao YumengBao force-pushed the feat/skills_in_ecs branch from c17d17d to 9a4982e Compare March 8, 2026 07:09
Copy link
Copy Markdown

@JiwaniZakir JiwaniZakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

identify_volc_env() in both skills_download.py and skills_register.py uses print() instead of return, so the function always returns None. This means VOLC_ENV == "vefaas" and VOLC_ENV == "ecs" will never be True, silently bypassing all credential resolution for both environments — this is a critical logic bug.

Additionally, get_credential_from_ecs_iam() has a potential UnboundLocalError: if requests.get() raises a RequestException, the exception is caught and printed, but data is never assigned, yet execution falls through to data.get("AccessKeyId") on the return statement. The function should either re-raise the exception or return early/None on failure rather than swallowing the error and proceeding.

The IAM role name AgentKit_Runtime_Default_ServiceRole_8xfe4ne is hardcoded in the metadata URL in both files — this should be configurable via an environment variable (similar to how AGENTKIT_SKILL_HOST and AGENTKIT_TOOL_REGION are handled), since different deployments will have different service roles.

Finally, identify_volc_env(), VeECSCredential, and get_credential_from_ecs_iam() are duplicated verbatim across both scripts; these belong in a shared utility module to avoid drift between the two implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants