fix: handle OOM correctly in parser and DOM code#135
Merged
Conversation
yangzhg
force-pushed
the
fix
branch
2 times, most recently
from
77d0cdb to
814a559
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #135 +/- ##
==========================================
- Coverage 74.79% 70.30% -4.49%
==========================================
Files 21 27 +6
Lines 2436 3789 +1353
Branches 667 1189 +522
==========================================
+ Hits 1822 2664 +842
+ Misses 297 212 -85
- Partials 317 913 +596 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yangzhg
force-pushed
the
fix
branch
4 times, most recently
from
51e7bd3 to
d4f9998
Compare
fix OOM handling in parser, SAX, and DOM paths avoid null dereferences during mutation and parsing add tests for parser, lazy parse, and DOM OOM cases
Collaborator
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5dbf83cb6f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix OOM handling in parser, SAX, and DOM paths
avoid null dereferences during mutation and parsing add tests for parser, lazy parse, and DOM OOM cases