Repository navigation
Results page: a pencil by the genes edits them, and Modify query open… - #79
Merged
Merged
Conversation
…s in a dialog without Explore
The summary's gene chips end in a pencil (PortalSummary's onEditGenes) that opens the gene
query dialog, titled "Edit genes", on the page's own query; Submit opens the Results page for
the same studies and filters with the new genes. "Modify query" opens the study chooser in a
dialog instead of under the summary, and there the flow offers only "Query by gene" (QueryFlow's
explore={false}), whose gene dialog starts from the page's genes; the homepage keeps both.
Verified on the dev server (coadread_tcga_pub, "KRAS: MUT / BRAF") and by the e2e lane of
scripts/gate.sh (185 pass), whose homepage check now also asserts the dialog has no Explore
button and the pencil opens "Edit genes" on the page's genes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TyVfAhLnjshk2kWewGnLum
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s in a dialog without Explore
The summary's gene chips end in a pencil (PortalSummary's onEditGenes) that opens the gene query dialog, titled "Edit genes", on the page's own query; Submit opens the Results page for the same studies and filters with the new genes. "Modify query" opens the study chooser in a dialog instead of under the summary, and there the flow offers only "Query by gene" (QueryFlow's explore={false}), whose gene dialog starts from the page's genes; the homepage keeps both.
Verified on the dev server (coadread_tcga_pub, "KRAS: MUT / BRAF") and by the e2e lane of scripts/gate.sh (185 pass), whose homepage check now also asserts the dialog has no Explore button and the pencil opens "Edit genes" on the page's genes.
Claude-Session: https://claude.ai/code/session_01TyVfAhLnjshk2kWewGnLum