Fix BetterBlockPos leaking into block entity map, fixes #4307

[mankool0]

In these cases minecraft's functions getShape and getCollisionShape get called with BetterBlockPos and minecrafts block entity map doesn't contain that position yet then you'll get a crash.

The reachable function has a leak in BuilderProcess::toBreakNearPlayer:

if (!(curr.getBlock() instanceof AirBlock) && !(curr.getBlock() == Blocks.WATER || curr.getBlock() == Blocks.LAVA) && !valid(curr, desired, false)) {
    BetterBlockPos pos = new BetterBlockPos(x, y, z);
    Optional<Rotation> rot = RotationUtils.reachable(ctx, pos, ctx.playerController().getBlockReachDistance());
    if (rot.isPresent()) {
        return Optional.of(new Tuple<>(pos, rot.get()));
    }
}

And calculateBlockCenter has a leak in MovementTraverse::updateState as dest is protected final BetterBlockPos dest;:

// combine the yaw to the center of the destination, and the pitch to the specific block we're trying to break
// it's safe to do this since the two blocks we break (in a traverse) are right on top of each other and so will have the same yaw
float yawToDest = RotationUtils.calcRotationFromVec3d(ctx.playerHead(), VecUtils.calculateBlockCenter(ctx.world(), dest), ctx.playerRotations()).getYaw();

This fixes issue #4307

[ZacSharp]

Looks good.

Feel like #4501 would be more correct, but it's been sitting long enough, so might as well try to get this one in.

[ZacSharp]

Me is stupid, and did not notice you were pring this against 1.21.11. The dev branch is still 1.19.4 and will be 1.21.4 (probably once Unimined 1.4.2 releases) so you should target this at either of those branches (preferably 1.19.4, if possible).

[mankool0]

Sounds good, I'll make a new pr for 1.19.4. I just looked and saw that this was the most recently updated one, and thought it was the correct one.

[mankool0]

Closing in favor of the 1.19.4 branch PR #5006