fix: use expandTowards for elytra collision swept volume#5052
Open
CompileRider wants to merge 1 commit into
Open
fix: use expandTowards for elytra collision swept volume#5052CompileRider wants to merge 1 commit into
CompileRider wants to merge 1 commit into
Conversation
Replace hitbox.inflate(motion.x, motion.y, motion.z) with hitbox.expandTowards(motion.x, motion.y, motion.z) in ElytraBehavior.simulate() to create a directional swept volume that prevents tunneling through 1-block-thick obstacles at high flight speeds. expandTowards handles negative motion vectors correctly (unlike inflate which collapses the AABB) and provides full swept volume coverage (unlike move which only checks the destination hitbox). Fixes cabaletta#5049 Regression test for cabaletta#5047
CompileRider
force-pushed
the
fix/elytra-collision-expandTowards
branch
from
a42d953 to
35862c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hitbox.inflate(motion.x, motion.y, motion.z) with hitbox.expandTowards(motion.x, motion.y, motion.z) in ElytraBehavior.simulate() to create a directional swept volume that prevents tunneling through 1-block-thick obstacles at high flight speeds.
expandTowards handles negative motion vectors correctly (unlike inflate which collapses the AABB) and provides full swept volume coverage (unlike move which only checks the destination hitbox).
Fixes #5049
Regression test for #5047
UwU