Fix 500 error when picking Mauve, Olive, Mist or Taupe as the accent colour - #401
Merged
Merged
Conversation
…colour Co-authored-by: Claude <noreply@anthropic.com>
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting Mauve, Olive, Mist or Taupe (introduced to Filament's
Color::all()via Tailwind v4.2) as the status page accent colour via Manage Theme, currently throws a 500. ThemeData'sTHEMESandGRAYS(andTHEME_PAIRINGS) lists were hardcoded and weren't updated with the new shades, so they showed up as in the Accent dropdown with no definitions to back them. Choosing any of these broke every consumer of ThemeData.Changes
ThemeData::GRAYS, since they seemed like a right fit in the base colour set, and not accents.matchPairing()accepts?stringand falls back to zinc.accent_contentfalls back to the matched pairing.constant("Filament\Support\Colors\Color::{$pairingKey}")incompileCss()with a keyedColor::all()lookup, for the same reason as above; i.e. not to throw an invalid pairing.Tests
Added 'tests/Unit/Data/ThemeDataTest.php' that steps through every option the accent and accent-content dropdowns actually offer (derived from Color::all() rather than hardcoded) and asserts each one compiles.