Repository navigation
fix(runtime): don't drop a crash during recovery unwind (fixes CI hang) - #352
Merged
Merged
Conversation
beginAccountRecovery ignored exits while recovering[id] was still set. recoverAccount only clears it in its defer, after startAccount has already registered the new process and started its watcher, so a process exiting in that window was dropped and the account was never restarted. Queue the failure and re-enter recovery from the defer. Fixes the race-test hang in TestManagerEscalatesConsecutiveRestartBackoffSeparately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: an exit that arrives while
recovering[id]is still set (recoverAccount has started the new process but not yet run its defer) was silently ignored, so the account never restarted. Under -race this made TestManagerEscalatesConsecutiveRestartBackoffSeparately wait forever for the third start (failed on ea144da / ac164d2).Fix: queue the failure in
recoverPendingand re-enter recovery from the defer. Adds deterministic regression test TestManagerRecoversCrashDuringRecoveryUnwind (fails without the fix).