Repository navigation
fix(console): instant skeleton→content swap, no fade/entrance animations - #356
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User feedback on 8d6879a: request history still flashed after skeleton.
Remaining causes: (1) useSkeletonExit faded the whole page 0→1 (260ms) right after the skeleton, and useSkeletonSwap faded/height-animated list cards; (2) HeroUI Tabs indicator animated width/height/translate on mount; (3) refetch dimmed the card to 60% with a transition; (4) useTabPanelSlide slid/faded panels on tab switch; data-gsap-reveal markers on logs content.
Changes: removed useSkeletonSwap/useSkeletonExit hooks and all usages (all pages), removed useTabPanelSlide (logs was the only user), removed data-gsap-reveal and the dim on the logs page, Tabs.Indicator transition-none. Skeletons are kept; refetches keep current rows in place.
Verified (Playwright, mocked API with 600–900ms delay): after skeleton disappears content effective opacity = 1 on first frame and no element's opacity/transform/visibility changes over the next 500ms, and no animations run in main — for initial load, page 2, filter change, tab switch both ways, and 3.8s of runtime auto-refresh polling. Only remaining: pagination button background-color hover transition.