[sethforprivacy]

ZEC has no USDT market on Kraken (only ZEC/USD and ZEC/EUR), so every ZEC sale goes through USD. That path had three problems, all fixed here.

1. It paged every pass. The route was found by requesting ZECUSDT and catching the failure. Each failed call printed two error lines every 30-90s, so prod's Autoforwarder: errors in the autoconvert log trigger opened at 19:35 UTC once ZEC was in AUTOCONVERT_ASSETS. Routes now come from a single AssetPairs listing, so a missing market is just a lookup miss. If there is no route at all, that is still raised as an error.
2. The second leg could never fill. Buys used the sell formula, so the USD→USDT IOC buy was limited at mid × (1 − slippage), below the book, and would be cancelled with nothing filled. Every ZEC sale would have ended up sitting in USD. A buy is now limited above mid and sized at the ask, with a fee margin (KRAKEN_FEE_MARGIN_PERCENT, default 0.5).
3. The second leg spent the whole USD balance, not just this sale's proceeds. It now spends only the increase since the first leg (polled for up to 30s). If no proceeds show up, it raises an error saying what to convert by hand.

In a dry run, the second leg is now validated using the first leg's expected proceeds. Before this, a dry run skipped the second leg entirely, which is why the staging run of T13 never caught problem 2.

Checked against live Kraken data (private calls stubbed, nothing sent):

• 1366 pairs loaded; XBT, LTC and XMR route directly, ZEC routes via USD.
• The ZEC sale would sell 1.74715603 ZEC at a limit of 1191.39 (bid 1197.23).
• It would then buy 2053.05 USDT at a limit of 1.00379 (ask 0.99880).

Tests:

• The Kraken fake is now a small market. A live IOC order fills only when its limit crosses the book, and unknown pairs are rejected the way Kraken rejects them.
• A ZEC sale is added to DryRunNeverMovesFunds.
• IndirectSale checks two things: the proceeds reach USDT while USD the account already held is untouched, and routing around the missing market logs nothing Zabbix counts as an error.
• Mutation-checked: each of these makes a test fail:
  • a buy limited below mid;
  • spending the whole USD balance;
  • the old probe-and-catch routing;
  • a dry run that places the second leg.

Follow-up in cake-tech/ansible: re-pin autoforward_version to this PR's merge commit.

🤖 Generated with Claude Code