Repository navigation
electrum: 4.8.3 for BTC and LTC; refuse random servers on mainnet - #8
Merged
Merged
Conversation
Electrum 4.8.3 is a security release (GHSA-6jp4-8v48-cc5v: a malicious server can replace a just-broadcast transaction), and 4.7.0-4.8.2 were security releases too. Electrum-LTC 4.8.3 tracks it. - BTC: Electrum-4.8.3.tar.gz, signatures from ThomasV, SomberNight and Emzy verified. - LTC: electrum-ltc-4.8.3-x86_64.AppImage, signed by the same key (7FE6094DCB3A76262EE4C6896EC371A844F2C48E, Hector Chu) as 4.6.2-3. The RPCs autoforward and the seed importer call have the same signatures in 4.8.3; only payto lost nocheck, which we never pass. An empty ELECTRUM_SERVER_ADDRESS let Electrum pick random public servers. On mainnet the entrypoints now refuse to start instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps both Electrum images to 4.8.3, and makes the Electrum containers refuse to start on mainnet with no pinned server.
Why
Electrum 4.8.3 is a security release. It fixes GHSA-6jp4-8v48-cc5v (high): a malicious server can replace a transaction you just broadcast. 4.7.0 through 4.8.2 were also security releases, and we were still on 4.6.2. Electrum-LTC 4.8.3 is the Litecoin port of the same release.
With
ELECTRUM_SERVER_ADDRESSempty, Electrum connects to random public servers. Production and staging already pin our own servers with--oneserver. Now the entrypoint also enforces it: on mainnet an empty address is a startup error, not a silent fallback. Testnet behaves as before.Verification
Electrum-4.8.3.tar.gz. Good signatures from ThomasV, SomberNight (release key) and Emzy, using the keys in spesmilo/electrum'spubkeys/.electrum-ltc-4.8.3-x86_64.AppImage. Good signature from7FE6094DCB3A76262EE4C6896EC371A844F2C48E(Hector Chu), the same key that signed the 4.6.2-3 and 4.7.0 builds.paytodroppednocheck, which we never pass.fee_policy.defaultis unchanged.btc-electrum.cakewallet.comit reports version 4.8.3,auto_connect: falseandspv_nodes: 1.auto_connect: falseandspv_nodes: 1on our servers. Balances and receiving-address counts match the pre-upgrade baseline. BTC and LTC forwards were built and signed (dry run), XMR was builtdo_not_relay, and ZEC reported "would sweep". There were no Electrum errors. Both images built on the host exit 1 when the server is blank andTESTNET=0. The wallet volumes were backed up before the upgrade.