Skip to content

Await the completed NOTIFY task in BlindTransferTests #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calebtt merged 1 commit into from
Sep 26, 2026
Merged

Await the completed NOTIFY task in BlindTransferTests #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/SipBotLib.Tests/BlindTransferTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ public async Task Final_progress_NOTIFY_is_answered_before_the_BYE()

Assert.True(transferred);
Assert.True(await Within(_notifyAnswered.Task, TimeSpan.FromSeconds(5)), "the NOTIFY got no final response");
var (status, answeredAt) = _notifyAnswered.Task.Result;
var (status, answeredAt) = await _notifyAnswered.Task;
Assert.Equal(SIPResponseStatusCodesEnum.Ok, status);
Assert.True(await Within(_byeAtCallee.Task, TimeSpan.FromSeconds(5)), "the transferee never received a BYE");
Assert.True(_byeAt >= answeredAt, $"BYE at {_byeAt} came before the NOTIFY was answered at {answeredAt}");
Expand Down
Loading