refactor: extract durable capture resource lifecycle - #1720
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
|
Exact-head review at Two validation gates remain open:
Finally, the PR declares no linked issue or stack dependency despite being the substrate for the recording cutover. Link the ADR 0019 tracker/checkpoint and the stacked recording/#1117 unit so the intended sequence and acceptance behavior are reviewable. No ready label applied. |
|
Exact-head follow-up for Non-vacuous regression evidenceI planted a representative delegation bypass in Red: 9/18 failed. The failures covered missing live-handle adoption, cancellation compensation, cleanup-pending evidence, envelope identity validation, tombstones, and same-process admission blocking. Restoring the delegation returned the same suite to 18/18 green. The existing structural guard was also re-proven through its planted cases: Exact-head live route evidenceFreshness: pinned pnpm install, Android emulator
iOS simulator
Guarded dead-owner recovery
All three named sessions were closed and the isolated daemon was stopped. HarmonyOS/HDC remains the explicit residual live-evidence gap because no provisioned Harmony target is available; its deterministic package/runtime tests remain the evidence for that route. |
|
Exact-head follow-up at
No source defect found, the size delta is small, all checks are green, and the PR is CLEAN/MERGEABLE. |
Summary
Extract the reusable daemon lifecycle substrate for durable captures and migrate app-log onto it without changing CLI or platform behavior.
The coordinator now owns manifest I/O, fenced transitions, start/adoption compensation, exact-owner recovery, and process-lifetime admission uncertainty. App-log keeps its specialized marker policy and runtime binding adapter. ADR 0019 records this bounded seam before the stacked screen-recording cutover.
Stack/tracking: #1117 (screen-recording cutover), #1704 (budget/distribution decision), and the ADR 0019 checkpoint sequence completed by #1703.
Validation
pnpm check:affected --runpassed with host networking: all seven selected checks and 710/710 related tests. The staged structural scan also passed 131 policy tests and the full 1,165-file layering guard.Exact-head live app-log lifecycle/recovery evidence and planted-red evidence are being gathered in response to the current review; this draft remains not ready until those are posted.