refactor: share daemon HTTP contract helpers#846
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
ff1fd95 to
7ea6869
Compare
Member
Author
|
#846 is merge-ready from review. I checked the daemon HTTP helper refactor against proxy, remote client transport, upload, and artifact download paths; all required checks are green, and there are no findings. Residual risk is low and limited to unusual daemon base URLs with query/hash components, which were not an existing documented contract. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Share daemon HTTP base-path URL and auth-header helpers across proxy, remote daemon client transport, uploads, and artifact downloads.
Keep proxy/connect orchestration separate; only the low-level daemon HTTP contract moved behind focused helpers.
Validation
Focused daemon HTTP/proxy/client/upload tests passed, TypeScript passed, unit tests passed, and smoke tests passed.
Commands run:
pnpm check:unit did not reach project scripts because pnpm 11.1.2 signature verification failed before execution, so I ran the equivalent unit and smoke commands directly.