fix: validate batch steps through command contracts#848
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
Member
Author
|
#848 is merge-ready from review. Current checks are fully green. I checked the batch projection path: nested structured input now goes through command metadata before daemon request projection, invalid input fails before daemon transport, and the regression covers the missing |
thymikee
force-pushed
the
codex/validate-batch-command-contracts
branch
from
2c13157 to
b597ff3
Compare
thymikee
force-pushed
the
codex/validate-batch-command-contracts
branch
from
b597ff3 to
0061994
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Structured batch steps now validate through command metadata before daemon projection, so invalid command input is rejected before CLI-shaped positionals are produced.
Added a regression for a focus step missing its y coordinate to prove the daemon is not called and no undefined positional leaks through.
Touched files: 4. Scope stayed within command/batch projection.
Validation
Verified with formatting, quick static checks, and the focused batch CLI suite: pnpm format, pnpm check:quick, and pnpm exec vitest run src/commands/batch/cli.test.ts.