fix: avoid deprecated object form of CommonActions.navigate on tab press#538
Open
rayabelcode wants to merge 1 commit into
Open
fix: avoid deprecated object form of CommonActions.navigate on tab press#538rayabelcode wants to merge 1 commit into
rayabelcode wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
@react-navigation/routers7.6.0 (pulled in by@react-navigation/native7.3.x), passing an object toCommonActions.navigateis deprecated and logs a warning. BecauseNativeBottomTabViewdispatches the object form on tab selection, every tab press in an app on React Navigation 7.3+ now prints:This swaps it for the supported
navigate(name, params)signature. It's the same pattern@react-navigation/bottom-tabsuses for its own tab press handling (BottomTabBar.tsx):Behavior is unchanged: the action is still scoped to the tab navigator via
target: state.key, and the route is resolved by name within that navigator exactly as before. The only difference is the route'skeyis no longer spread into the action payload, which the v7 navigate action doesn't use for matching anyway.Repro: any app using
createNativeBottomTabNavigatorwith@react-navigation/native >= 7.3.0, press any unfocused tab, watch the console.