fix: check-expo-beta script not to conflict in WS#426
Merged
Conversation
Ensure expo install --fix runs through Yarn and is followed by a root yarn install so canary Expo packages (e.g. expo-image) are installed correctly. Skip setup in road-test actions for the Expo beta workflow to avoid reinstalling stable deps over the canary set. Ignore generated ExpoAppBeta in apps.
artus9033
force-pushed
the
fix/expo-beta-test
branch
from
145ed99 to
32ca4e9
Compare
artus9033
force-pushed
the
fix/expo-beta-test
branch
from
8f927d2 to
b1703fc
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Expo “beta” road-test automation to a “preview” workflow by replacing the old ExpoAppBeta generation/check script with a new ExpoAppPreview flow, and wiring that through Android/iOS consumer build steps.
Changes:
- Replaced the Expo beta checker/generator script with a new Expo preview checker/generator (
check-expo-preview.ts) and matching tests. - Renamed and rewired CI, Android flavors, and AppleApp variants from
expobeta/ExpoAppBetatoexpopreview/ExpoAppPreview. - Updated navigation spec and documentation to include consumer road-test navigation methods and reflect the new “preview” naming.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/check-expo-preview.ts | New script to detect latest Expo preview release and generate/update apps/ExpoAppPreview on demand. |
| scripts/check-expo-beta.ts | Removes the previous beta-specific script. |
| scripts/tests/check-expo-preview.test.ts | Adds unit tests for preview version selection and string rewriting utilities. |
| scripts/tests/check-expo-beta.test.ts | Removes beta script tests. |
| apps/README.md | Renames documentation references from Expo beta app to Expo preview app. |
| apps/ExpoApp57/brownfield.navigation.ts | Adds consumer road-test navigation methods to the template navigation spec. |
| apps/AppleApp/package.json | Renames AppleApp build script variant from expobeta to expopreview. |
| apps/AppleApp/Brownfield Apple App.xcodeproj/xcshareddata/xcschemes/Brownfield Apple App Expo Preview.xcscheme | Renames scheme buildable references from Beta to Preview. |
| apps/AppleApp/Brownfield Apple App.xcodeproj/project.pbxproj | Renames target/product from Beta to Preview and updates framework embedding for the Preview target. |
| apps/AndroidApp/package.json | Renames Android consumer build script variant from expobeta to expopreview. |
| apps/AndroidApp/gradle/libs.versions.toml | Renames Maven dependency alias from expobeta to expopreview and updates module coordinates. |
| apps/AndroidApp/app/src/expopreview/java/com/callstack/brownfield/android/expo/ReactNativeHostManager.kt | Adds Preview flavor typealias for host manager. |
| apps/AndroidApp/app/src/expopreview/java/com/callstack/brownfield/android/expo/ReactNativeConstants.kt | Adds Preview flavor constants (app name, module name). |
| apps/AndroidApp/app/src/expopreview/java/com/callstack/brownfield/android/expo/BrownfieldStore.kt | Adds Preview flavor typealiases for store/user types. |
| apps/AndroidApp/app/build.gradle.kts | Renames the Android product flavor from expobeta to expopreview. |
| apps/.gitignore | Ignores generated ExpoAppPreview directory under apps/. |
| .github/workflows/expo-preview-road-test.yml | Renames workflow to “preview”, switches to preview script/app, and updates artifact/issue naming. |
| .github/actions/appleapp-road-test/action.yml | Adds skip-setup option so workflows can pre-setup the monorepo. |
| .github/actions/androidapp-road-test/action.yml | Adds skip-setup option so workflows can pre-setup the monorepo. |
Comments suppressed due to low confidence (2)
.github/workflows/expo-preview-road-test.yml:7
- The workflow is configured to run on pushes to a specific branch (
fix/expo-beta-test). This looks like a temporary debug trigger and will either never run after merge (if the branch is deleted) or run unexpectedly if someone recreates the branch. Prefer relying onschedule/workflow_dispatchfor this road-test workflow.
.github/workflows/expo-preview-road-test.yml:30 node --experimental-strip-typesis used before any Node version is set up. This makes the workflow depend on whatever Node happens to be preinstalled onubuntu-latest, and--experimental-strip-typesavailability can change across runner images. Add an explicitactions/setup-nodestep (matching the repo’s other workflows) before running the script.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This reverts commit 32ca4e9.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
hurali97
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PRs fixes the Expo beta test workflow.
Test plan
CI green or sensible error due to incompat with Expo beta (manual dispatch).