PoC: move Props type below component - #3833
Draft
DimitarNestorov wants to merge 1 commit into
Draft
DimitarNestorov wants to merge 1 commit into
DimitarNestorov wants to merge 1 commit into
Conversation
|
Hey @DimitarNestorov, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
The mobile version of example app from this branch is ready! You can see it here. |
lukewalczak
force-pushed
the
main
branch
6 times, most recently
from
May 8, 2025 09:47
1062366 to
1da5d15
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The change only reorders a type declaration without behavioral or API changes.
Pull request overview
Moves the exported Button props type below the component without changing runtime behavior or the public API.
Changes:
- Relocates the
Propstype declaration.
File summaries
| File | Description |
|---|---|
src/components/Button/Button.tsx |
Reorders the exported props type declaration. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan