Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c3dd06111
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,3 +1,6 @@ | |||
| export type { AppErrorCode } from './utils/errors.ts'; | |||
| export { defaultHintForCode, normalizeError } from './utils/errors.ts'; | |||
There was a problem hiding this comment.
Re-exporting normalizeError from agent-device/contracts now forces that module to load src/utils/errors.ts, which in turn imports src/utils/diagnostics.ts and its Node built-ins (node:async_hooks, node:fs, etc.). This breaks consumers that use the contracts entrypoint in non-Node runtimes (browser/edge/worker) with module-resolution errors, whereas this file was explicitly kept dependency-free for bridge/cloud contract validation.
Useful? React with 👍 / 👎.
thymikee
force-pushed
the
codex/issue-390-export-errors-contract
branch
2 times, most recently
from
982b65c to
b3960a5
Compare
|
thymikee
force-pushed
the
codex/issue-390-export-errors-contract
branch
from
b3960a5 to
c3c23bf
Compare
1 participant
Summary
AppErrorCode,normalizeError, anddefaultHintForCodefromagent-device/contracts.AppErrorCodewhile keeping normalization and hint behavior unchanged.defaultHintForCodeaccepting wirestringcodes for publicDaemonErrorcallers.Touched files: 3. Scope stayed within error contract export surface. Docs/skills were not updated because this is a library API export, not CLI behavior.
Closes #390
Validation
pnpm installpnpm formatpnpm check:quickKnown gaps: none.