Skip to content

Stale JSDoc: CordieriteConnectOptions.linkPin still says link trust is debug-build-only #38

Description

@V3RON

Found while reviewing #33.

packages/react-native/src/Cordierite.types.ts:57-63 documents linkPin as trusted only "when built in debug mode with no build-time cliPins configured" and says "release builds without pins keep the existing hard error". That predates the explicit trust mode: resolveTrustedPins on both platforms consults no build-type signal, and docs/SECURITY.md "Trust modes" describes link trust as available in any build type when no cliPins are configured.

Fix: reword the comment to match docs/SECURITY.md (trust mode "link" is the default whenever cliPins is empty, in every build type; embedded pins always win). No behaviour change.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions