fix: React Native 0.83+ CRTP codegen compatibility#138
Open
yocontra wants to merge 1 commit intocallstackincubator:masterfrom
Open
fix: React Native 0.83+ CRTP codegen compatibility#138yocontra wants to merge 1 commit intocallstackincubator:masterfrom
yocontra wants to merge 1 commit intocallstackincubator:masterfrom
Conversation
React Native 0.83 switched TurboModule codegen from virtual inheritance to CRTP (Curiously Recurring Template Pattern). This changes the base class from `NativePolygenCxxSpecJSI` to `NativePolygenCxxSpec<ReactNativePolygen>` and removes `override` keywords from method declarations, since CRTP uses static dispatch rather than virtual dispatch. Also adds the required `page_size` argument (65536) to `wasm_rt_allocate_memory` for wabt 1.0.39 compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NativePolygenCxxSpec<ReactNativePolygen>instead ofNativePolygenCxxSpecJSI, and removesoverridekeywords since CRTP uses static dispatch rather than virtual dispatch.page_sizeargument (65536) towasm_rt_allocate_memoryfor wabt 1.0.39 compatibility.Changes
ReactNativePolygen.hNativePolygenCxxSpecJSItoNativePolygenCxxSpec<ReactNativePolygen>overridekeyword from all method declarations (CRTP uses static dispatch)ReactNativePolygen.cppNativePolygenCxxSpecJSItoNativePolygenCxxSpecWebAssembly/Memory.hpage_sizeargument (65536) towasm_rt_allocate_memorycall for wabt 1.0.39 API compatibilityTest plan