Skip to content

feat(#9): provide customization options to the underlying native licenses#125

Open
californiandreamer wants to merge 2 commits intocallstackincubator:mainfrom
californiandreamer:feat/native-license-options
Open

feat(#9): provide customization options to the underlying native licenses#125
californiandreamer wants to merge 2 commits intocallstackincubator:mainfrom
californiandreamer:feat/native-license-options

Conversation

@californiandreamer
Copy link
Copy Markdown

This PR introduces configurable AboutLibraries (--gitHubApiToken) and LicensePlist (--github-token, --add-version-numbers) token options for the Expo plugin and RN CLI.

+ "transitiveDepsMode": "all"
+ "transitiveDepsMode": "all",
+ "aboutLibraries": {
+ "gitHubApiToken": "YOUR_GITHUB_TOKEN"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need two different tokens for each of the platforms?

// `'none'` (no transitive dependencies of direct dependencies)
// @default `'all'`
transitiveDepsMode?: 'all' | 'from-external-only' | 'from-workspace-only' | 'none';
aboutLibraries?: {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdyt about renaming those fields to androidOptions and iosOptions?

@mateusz1913
Copy link
Copy Markdown
Collaborator

@californiandreamer thanks for the PR, I'll try to play with it next week and then we can think about merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants