docs(delivery),chore(skills): two blind reviews before every PR — rule 14 and the review skill - #146
Merged
Merged
Conversation
…e 14 and the review skill A PR now arrives reviewed. Rule 14 makes review part of delivery the way rule 9 makes verification part of it: a spec review that holds the issue and never the rules, and a code review that holds the rules and never the issue, each by a fresh sub-agent blind to the delivering session. Findings are claims the delivering agent verifies, fixes or rejects with a reason in a Review section of the PR body; two rounds at most, then a handoff. The new review skill encodes the procedure and the two reviewer briefs; the deliver skill calls it as step 4a; DELIVERY.md explains why the two reviewers are blind to each other. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QWDWCVbyyrUAmtmjiALt7h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The delivery rules said nothing about code review. Now a PR arrives reviewed; it is not reviewed on arrival.
Rule 14 in
docs/internal/agent-rules/delivery.md: before opening a PR, the delivering agent runs two reviews of the diff, each by a fresh sub-agent on the most capable model available, blind to the delivering session and to each other.Findings are claims: the agent verifies each, fixes what it confirms, and lists what it rejects in a
## Reviewsection of the PR body with one reason per line. Two rounds at most; a blocking finding still open after that is a handoff, not a PR.Files
docs/internal/agent-rules/delivery.md— rule 14; the Review section joins the checklist outside the PR body budget in rule 12..claude/skills/review/SKILL.md— new skill: gathers the inputs into a directory so each reviewer sees exactly what it is given, the two reviewer briefs verbatim, the verify-fix-reject loop, the Review section. Also runs on a person's PR, posting findings as a comment instead of pushing..claude/skills/deliver/SKILL.md— step 4a calls the review skill; the PR body carries the Review section; an open blocking finding is a stop reason.docs/internal/DELIVERY.md— "Review before the PR" section explaining why the two reviewers are blind to each other; walkthroughs and pointers updated.AGENTS.md— one clause in the delivery summary.Docs and skills only;
pnpm format:checkpasses. The two reviews were not run on this PR itself, since there is no code diff for the code reviewer and no issue for the spec reviewer.🤖 Generated with Claude Code
https://claude.ai/code/session_01QWDWCVbyyrUAmtmjiALt7h
Written by an agent.
Generated by Claude Code