Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-live-activity-naming.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'voltra': patch
---

Fix iOS Live Activity naming so named activities can be reused more reliably across app launches.
2 changes: 1 addition & 1 deletion packages/ios-client/src/VoltraModule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import type {
export type StartVoltraOptions = {
target?: string
deepLinkUrl?: string
activityId?: string
activityName?: string
staleDate?: number
relevanceScore?: number
channelId?: string
Expand Down
2 changes: 1 addition & 1 deletion packages/ios-client/src/live-activity/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ export const startLiveActivity = async (
const targetId = await VoltraModule.startLiveActivity(payload, {
target: 'liveActivity',
deepLinkUrl: options?.deepLinkUrl,
activityId: options?.activityName,
activityName: options?.activityName,
channelId: options?.channelId,
...normalizedSharedOptions,
})
Expand Down
2 changes: 1 addition & 1 deletion packages/voltra/src/VoltraModule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export type StartVoltraOptions = {
* The ID/name of the Live Activity.
* Allows you to rebind to the same activity on app restart.
*/
activityId?: string
activityName?: string
/**
* Unix timestamp in milliseconds
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ describe('Live Activity Options', () => {

expect(VoltraModule.startLiveActivity).toHaveBeenCalledWith(
expect.anything(),
expect.objectContaining({ activityId: 'my-activity' })
expect.objectContaining({ activityName: 'my-activity' })
)
})
})
2 changes: 1 addition & 1 deletion packages/voltra/src/live-activity/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ export const startLiveActivity = async (
const targetId = await VoltraModule.startLiveActivity(payload, {
target: 'liveActivity',
deepLinkUrl: options?.deepLinkUrl,
activityId: options?.activityName,
activityName: options?.activityName,
channelId: options?.channelId,
...normalizedSharedOptions,
})
Expand Down
Loading