Convert directory-tree to TypeScript - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave-A TypeScript conversion (engines pilot pattern), with ONE disclosed behavior addition:
distjoins the transform's default ignore list — build artifacts leaked into the self-rendered README tree, and CI regenerates docs before building, so the committed tree must be dist-free (same trap class as phase 2's .turbo ghost; changeset documents it). Review verified regen-before-build AND regen-after-build both stay dist-free.Types:
@types/archy(shapes verified) + directory-tree's own shipped types; the phase-1attributes: ['type']fix preserved verbatim. Reviewer note (recorded):node.children ?? []is a type-safety accommodation — the undefined branch is unreachable with this plugin's options (verified against directory-tree@3.6.0 source).Validation: typecheck + lint + prettier clean · workspace tests green · tarball gate incl. consumer-typecheck · node example.ts exit 0 · docs idempotent in both build orderings · code-reviewed (APPROVE)