CI: build before lint and docs - #18
Merged
Merged
Conversation
converted packages' exports resolve to dist/, and the root example.js imports them by package name — lint and docs need dist present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #8 exposed an ordering gap: eslint's import resolver (and the root dogfood example.js) resolve converted packages by name through their
exports, which now point atdist/— but CI built LAST. First converted-package PR that something imports by name → lint fails; would break main after merge too.Fix:
pnpm -r buildmoves directly after install. Safe in all orderings: directory-tree's docs regen is dist-proof as of its conversion branch (dist joined its default ignore list), and no other package's docs output depends on build state.Docs-diff/carve-out/tarball semantics unchanged.