Convert version-badge to TypeScript - #9
Merged
Merged
Conversation
index.ts + types.ts + index.spec.ts + example.ts, tsconfig.build.json (rootDir/include root-relative for the flat plugin layout), dist packaging with prepack. Logic unchanged (incl. prerelease-orange color and fail-loud missing-package.json throw), types + syntax + .ts specifiers only. Adds @types/semver devDependency since the installed semver@7 package does not ship its own type declarations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave-A TypeScript conversion per the phase-3 plan (engines pilot pattern): index.ts + per-package types.ts (exported TransformArgs/TransformOptions), spec + example converted (.ts specifiers, native Node ≥22.18 type-stripping for dev), dist packaging (exports/types → dist/, files: ["dist"], prepack build), changeset minor (types added, zero runtime change).
Logic byte-for-byte vs main (review-verified line-by-line, incl. prerelease→orange and the fail-loud missing-package.json throw).
Package-specific:
@types/semverdevDep added — semver@7.8.5 ships no declarations (verified empirically; the plan's contrary claim was wrong).Validation: typecheck + lint + prettier clean · full workspace tests green · tarball gate incl. consumer-typecheck · node example.ts exit 0 · docs idempotent · code-reviewed (APPROVE)