fix: Add graceful embedding fallback to store_reasoning_memory#281
Open
kevinkre wants to merge 1 commit intocampfirein:mainfrom
Open
fix: Add graceful embedding fallback to store_reasoning_memory#281kevinkre wants to merge 1 commit intocampfirein:mainfrom
kevinkre wants to merge 1 commit intocampfirein:mainfrom
Conversation
kevinkre
commented
Oct 22, 2025
kevinkre
commented
- Create zero-vector fallback when embeddings fail
- Continue to text-only storage instead of failing
- Add usingEmbedding and storageMode indicators to response
- Matches graceful fallback behavior of cipher_memory_search
- Enables memory storage even when embedding providers fail
- Create zero-vector fallback when embeddings fail - Continue to text-only storage instead of failing - Add usingEmbedding and storageMode indicators to response - Matches graceful fallback behavior of cipher_memory_search - Enables memory storage even when embedding providers fail
Collaborator
|
@codex review this PR |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Collaborator
|
@kevinkre thanks for your PR, can you double-check to make sure all tests are passed before I merge this PR? |
Test Confirmation ✅I've run the full test suite on the latest code including this PR's changes: All 2057 tests pass. The fallback behavior for embeddings is working correctly and maintains backward compatibility. Ready to merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.