add default values for openSUSE / SLES#78
Open
tampakrap wants to merge 3 commits intocamptocamp:masterfrom
Open
add default values for openSUSE / SLES#78tampakrap wants to merge 3 commits intocamptocamp:masterfrom
tampakrap wants to merge 3 commits intocamptocamp:masterfrom
Conversation
tampakrap
force-pushed
the
suse
branch
3 times, most recently
from
1c5ba29 to
f728f1e
Compare
saimonn
requested changes
Nov 24, 2016
Member
saimonn
left a comment
saimonn
left a comment
There was a problem hiding this comment.
Thanks for this PR. Can you please rebase on master ? this should fix the travis build 'json_pure' errors.
Also there's a lint error to fix:
manifests/config.pp - WARNING: ensure set to present on file resource on line 107
manifests/config.pp
Outdated
| 'recursion' => 'no', | ||
| if $::osfamily == 'Suse' { | ||
| file {'/etc/named.d/default-zones': | ||
| ensure => present, |
Member
There was a problem hiding this comment.
this should be 'file', not 'present'
Author
|
@saimonn sorry for the delay, I fixed the issue and rebased |
Contributor
|
Could you add SuSE to metadata.json and make sure it passes tests? |
tampakrap
force-pushed
the
suse
branch
2 times, most recently
from
7f6464c to
1503be7
Compare
Author
|
@raphink added, review please |
- create files/suse_default-zones, as the default zones are inside in /etc/named.conf in suse distros - do not create /var/log/bind on suse - do not create default_logging in suse - move the default_logging inside the distro defaults in params.pp - add empty default_logging hash in suse - do not create logging block in named.conf.options template if @logging is empty
raphink
suggested changes
Oct 19, 2018
Contributor
raphink
left a comment
raphink
left a comment
There was a problem hiding this comment.
LGTM, but some fails still fail on SuSE. Can you fix them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.