chore: add typing to cloudinit.distros.parsers hostname and resolv_conf#6909
Open
Ahmedaltu wants to merge 4 commits into
Open
chore: add typing to cloudinit.distros.parsers hostname and resolv_conf#6909Ahmedaltu wants to merge 4 commits into
Ahmedaltu wants to merge 4 commits into
Conversation
canonicalGH-5445 Signed-off-by: Ahmed <76178825+Ahmedaltu@users.noreply.github.com>
Signed-off-by: Ahmed <76178825+Ahmedaltu@users.noreply.github.com>
Signed-off-by: Ahmed <76178825+Ahmedaltu@users.noreply.github.com>
2 tasks
holmanb
requested changes
Jun 30, 2026
holmanb
left a comment
holmanb
left a comment
Member
There was a problem hiding this comment.
Thanks for this proposal. Please merge the latest tip of main to pick up fixes for the failing tests.
| def parse(self): | ||
| if self._contents is None: | ||
| def parse(self) -> None: | ||
| if not self._parsed: |
Member
There was a problem hiding this comment.
Rather than adding a new boolean can we just check if _parsed is truthey? Same comment throughout the rest of this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: add typing to cloudinit.distros.parsers hostname and resolv_conf
Add type annotations to fix check_untyped_defs mypy errors in:
Use a _parsed flag to track parse state rather than checking truthiness
of _contents, since an empty list [] is a valid parsed result for empty
or comment-only input files.
Removes both modules from the mypy disabled list in pyproject.toml.
Fixes GH-5445